Bug 188785

Summary: Allow creating WeakPtrs to const objects
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, realdawei, sam, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Antti Koivisto 2018-08-21 05:03:47 PDT 
const Foo foo;
auto weakFoo = makeWeakPtr(foo);

should work.
Comment 1 Antti Koivisto 2018-08-21 06:16:30 PDT 
Created attachment 347638 [details]
patch
Comment 2 Geoffrey Garen 2018-08-21 09:59:33 PDT 
Comment on attachment 347638 [details]
patch

r=me
Comment 3 WebKit Commit Bot 2018-08-21 12:09:37 PDT 
Comment on attachment 347638 [details]
patch

Clearing flags on attachment: 347638

Committed r235129: <https://trac.webkit.org/changeset/235129>
Comment 4 WebKit Commit Bot 2018-08-21 12:09:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-21 12:10:24 PDT 
<rdar://problem/43571796>
Comment 6 Dawei Fenton (:realdawei) 2018-08-23 16:36:14 PDT 
Reverted r235129 for reason:

broke internal builds

Committed r235258: <https://trac.webkit.org/changeset/235258>
Comment 7 Antti Koivisto 2018-08-24 00:49:39 PDT 
Created attachment 347996 [details]
patch
Comment 8 Antti Koivisto 2018-08-24 01:25:53 PDT 
Created attachment 347999 [details]
patch
Comment 9 WebKit Commit Bot 2018-08-24 02:30:59 PDT 
Comment on attachment 347999 [details]
patch

Clearing flags on attachment: 347999

Committed r235315: <https://trac.webkit.org/changeset/235315>
Comment 10 WebKit Commit Bot 2018-08-24 02:31:00 PDT 
All reviewed patches have been landed.  Closing bug.