| Summary: | Move legacy directory configuration from WebProcessPool to API::WebsiteDataStore | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||||||||||||||
| Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, berto, cgarcia, commit-queue, ews-watchlist, ggaren, gustavo, mcatanzaro, rniwa, tsavell, webkit-bug-importer | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Bug Depends on: | 188887 | ||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Sihui Liu
2018-08-20 16:41:06 PDT
Created attachment 347570 [details]
Patch
Created attachment 347656 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 347663 [details]
Patch
Created attachment 347680 [details]
Patch
Created attachment 347691 [details]
Patch
Comment on attachment 347691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347691&action=review > Source/WebKit/ChangeLog:7 > + Please explain why we want to do this in the change log. Comment on attachment 347691 [details] Patch Attachment 347691 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8935679 New failing tests: http/wpt/workers/name-property-enhanced.html Created attachment 347722 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347691 [details] Patch Attachment 347691 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8939324 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html Created attachment 347759 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 347813 [details]
Patch
(In reply to Ryosuke Niwa from comment #7) > Comment on attachment 347691 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347691&action=review > > > Source/WebKit/ChangeLog:7 > > + > > Please explain why we want to do this in the change log. Information added! Comment on attachment 347813 [details]
Patch
r=me
Comment on attachment 347813 [details] Patch Clearing flags on attachment: 347813 Committed r235216: <https://trac.webkit.org/changeset/235216> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 188887 This patch: https://trac.webkit.org/changeset/235216/webkit Caused 50+ Layout Tests to Crash and 173 api Failures on Debug builds: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/4593 Rollout out in: https://trac.webkit.org/changeset/235224/webkit Created attachment 347942 [details]
Patch
Comment on attachment 347942 [details]
Patch
r=me
Comment on attachment 347942 [details] Patch Clearing flags on attachment: 347942 Committed r235260: <https://trac.webkit.org/changeset/235260> All reviewed patches have been landed. Closing bug. |