| Summary: | [WebGL] Contexts are not updated when display configuration changed. | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||||||||||||||
| Component: | WebGL | Assignee: | Per Arne Vollan <pvollan> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, dino, ews-watchlist, graouts, justin_fan, kondapallykalyan, rniwa, simon.fraser, webkit-bug-importer | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Per Arne Vollan
2018-08-20 11:16:19 PDT
Created attachment 347540 [details]
Patch
Created attachment 347567 [details]
Patch
Comment on attachment 347567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347567&action=review Looks like a good change. r=me (but please confirm EWS is happy). > Source/WebCore/platform/graphics/GraphicsContext3DManager.h:28 > +#include <WebCore/Timer.h> Do we need to prefix this with WebCore when building in WebCore? Or is this header accessed outside WebCore? > Source/WebCore/platform/graphics/GraphicsContext3DManager.h:71 > + Please remove this whitespace-only change. Comment on attachment 347567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347567&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=188750 Is there a radar associated with this? (In reply to Brent Fulgham from comment #3) > Comment on attachment 347567 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347567&action=review > > Looks like a good change. r=me (but please confirm EWS is happy). > > > Source/WebCore/platform/graphics/GraphicsContext3DManager.h:28 > > +#include <WebCore/Timer.h> > > Do we need to prefix this with WebCore when building in WebCore? Or is this > header accessed outside WebCore? Yes, this file is now accessed from WebKit. > > > Source/WebCore/platform/graphics/GraphicsContext3DManager.h:71 > > + > > Please remove this whitespace-only change. Will do. I will also create a radar. Thanks for reviewing! Created attachment 347587 [details]
Patch
Comment on attachment 347587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347587&action=review > Source/WebCore/platform/graphics/GraphicsContext3DManager.h:28 > +#include <WebCore/Timer.h> I think this should just be "#include "Timer". > Source/WebKit/UIProcess/API/C/mac/WKMockDisplay.h:35 > + WK_EXPORT void WKSendDisplayConfigurationChangedMessageForTesting(WKContextRef); No indenting here. Comment on attachment 347567 [details] Patch Attachment 347567 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8924002 New failing tests: fast/canvas/webgl/context-update-on-display-configuration.html Created attachment 347589 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347567 [details] Patch Attachment 347567 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8924280 New failing tests: fast/canvas/webgl/context-update-on-display-configuration.html Created attachment 347594 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 347567 [details] Patch Attachment 347567 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8924003 New failing tests: fast/canvas/webgl/context-update-on-display-configuration.html Created attachment 347596 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
(In reply to Simon Fraser (smfr) from comment #8) > Comment on attachment 347587 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347587&action=review > > > Source/WebCore/platform/graphics/GraphicsContext3DManager.h:28 > > +#include <WebCore/Timer.h> > > I think this should just be "#include "Timer". > > > Source/WebKit/UIProcess/API/C/mac/WKMockDisplay.h:35 > > + WK_EXPORT void WKSendDisplayConfigurationChangedMessageForTesting(WKContextRef); > > No indenting here. Thanks for reviewing! I will update the patch. Comment on attachment 347587 [details] Patch Attachment 347587 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8926046 New failing tests: fast/canvas/webgl/context-update-on-display-configuration.html Created attachment 347608 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 347642 [details]
Patch
Created attachment 347646 [details]
Patch
Created attachment 347650 [details]
Patch
Comment on attachment 347650 [details] Patch Clearing flags on attachment: 347650 Committed r235125: <https://trac.webkit.org/changeset/235125> Landed a build fix in https://trac.webkit.org/changeset/235154. |