Bug 188739

Summary: Don't place "using namespace XXX;" in global space for unified source builds
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: New BugsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, keith_miller, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Fujii Hironori 2018-08-19 22:41:30 PDT 
Don't place "using namespace XXX;" in global space for unified source builds

(In reply to Yusuke Suzuki from bug #188589 comment #25)
> Maybe, I think we should remove `using namespace XXX` as much as possible
> since we are now deploying unified builds. But I think this should be done
> in a separate patch.

(In reply to Darin Adler from bug #188589 comment #28)
> Yes, I think we should move this over time. Unified builds makes it a risky
> approach, and I think it’s always been risky from a "reduced clarity" point
> of view.
Comment 1 Fujii Hironori 2018-08-21 02:43:04 PDT 
Created attachment 347624 [details]
Patch
Comment 2 Fujii Hironori 2018-08-21 03:10:33 PDT 
Created attachment 347625 [details]
Patch
Comment 3 Fujii Hironori 2018-08-21 03:47:30 PDT 
Created attachment 347626 [details]
Patch
Comment 4 Yusuke Suzuki 2018-08-21 06:14:34 PDT 
Comment on attachment 347626 [details]
Patch

Nice! r=me
Comment 5 Fujii Hironori 2018-08-21 06:26:59 PDT 
Comment on attachment 347626 [details]
Patch

Thank you for the review!
Comment 6 WebKit Commit Bot 2018-08-21 06:55:20 PDT 
Comment on attachment 347626 [details]
Patch

Clearing flags on attachment: 347626

Committed r235115: <https://trac.webkit.org/changeset/235115>
Comment 7 WebKit Commit Bot 2018-08-21 06:55:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-08-21 06:56:22 PDT 
<rdar://problem/43559532>