| Summary: | [GTK] Sort inspector GResource manifest to ensure reproducible builds | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bernhard M. Wiedemann <webkitbmw> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, commit-queue, mcatanzaro | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Bernhard M. Wiedemann
2018-08-19 21:57:40 PDT
Created attachment 347480 [details]
fixing patch
Comment on attachment 347480 [details]
fixing patch
Hi Bernhard! I think it would be fine to merge the patchit, but it would
need to follow the convention of including a ChangeLog entry. You can
generate one for your changes using “Tools/Scripts/prepare-ChangeLog”. If
you have a Git checkout, you can pass “-g <commitish>” to indicate for
which commit(s) the entry will be generated.
Could you please be so kind as to add the ChangeLog entry and re-submit
the patch? Thanks in advance!
Created attachment 347495 [details]
patch with changelog entry
Comment on attachment 347495 [details]
patch with changelog entry
In the future, you can use the r? and cq? flags to request review and commit, respectively.
Comment on attachment 347495 [details] patch with changelog entry Clearing flags on attachment: 347495 Committed r235080: <https://trac.webkit.org/changeset/235080> All reviewed patches have been landed. Closing bug. |