Bug 188692

Summary:

Replace canBubble and cancelable booleans in Event by enum classes

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

UI Events

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, darin, dbates, ews-watchlist, ggaren, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

188720

Attachments:

Description	Flags
Cleanup	none
GTK build fix attempt	achristensen: review+

Description Ryosuke Niwa 2018-08-16 22:34:39 PDT

Event::Event and Event::create take two booleans to indicate whether an event can bubble and whether it's cancelable.
Replace these booleans by enum classes to make the call sites more readable than Event::create(~, false, false).

Comment 1 Ryosuke Niwa 2018-08-16 22:40:54 PDT

Created attachment 347351 [details]
Cleanup

Comment 2 EWS Watchlist 2018-08-16 22:44:11 PDT

Attachment 347351 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:98:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 2 in 164 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Ryosuke Niwa 2018-08-16 23:11:24 PDT

Created attachment 347352 [details]
GTK build fix attempt

Comment 4 EWS Watchlist 2018-08-16 23:14:50 PDT

Attachment 347352 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/KeyboardEvent.cpp:98:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:41:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:41:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:42:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/TouchEvent.cpp:44:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 7 in 165 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Radar WebKit Bug Importer 2018-08-16 23:36:07 PDT

<rdar://problem/43411944>

Comment 6 Ryosuke Niwa 2018-08-17 14:24:43 PDT

Committed r234995: <https://trac.webkit.org/changeset/234995>

Comment 7 Ryosuke Niwa 2018-08-17 17:00:27 PDT

Committed r234999: <https://trac.webkit.org/changeset/234999>