| Summary: | Modernize results.html | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, Basuke.Suzuki, dbates, jbedard, joepeck, ross.kirsling, ryanhaddad, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=188927 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2018-08-16 21:18:18 PDT
Created attachment 347348 [details]
Patch
Comment on attachment 347348 [details]
Patch
r=me. Please confirm that the page still loads in other browsers - sometimes one's WebKit is so much under development that Safari won't launch to show the page :)
I tested current versions of Chrome and Firefox and both loaded the page fine. Ever since this patch, WinCairo layout tests which have a failing text diff and no -expected.png show up as "had no expected results (probably new)": Before: https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234991%20(1085)/results.html After: https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234993%20(1086)/results.html Now, this isn't a huge problem for us, as these test failures are all due to some bot image misconfiguration that we've yet to track down and not reproable locally, and presumably as soon as we fix the bot they'll all disappear anyway, but it is still weird that the dashboard now suggests a lack of expected results when you can clearly see otherwise. Could you file a new bug for that? Thanks! I did fix some fallout recently. (In reply to Simon Fraser (smfr) from comment #7) > Could you file a new bug for that? Thanks! I did fix some fallout recently. My pleasure! Submitted as bug 188927. |