| Summary: | [GStreamer][MSE] Remove parsers from playback pipeline | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboya, calvaris, eocanha, ews-watchlist, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Philippe Normand
2018-08-16 06:20:20 PDT
Created attachment 347257 [details]
Patch
Comment on attachment 347257 [details] Patch Attachment 347257 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8887030 New failing tests: http/tests/security/local-video-source-from-remote.html Created attachment 347333 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 347257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347257&action=review I would like Enrique or Alicia to comment on this before landing (after fixing the comments) > Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:178 > const char* mediaType = capsMediaType(caps); > GST_DEBUG_OBJECT(webKitMediaSrc, "Configured track %s: appsrc=%s, padId=%u, mediaType=%s", trackPrivate->id().string().utf8().data(), GST_ELEMENT_NAME(stream->appsrc), padId, mediaType); mediaType would be now used nowhere else, so variable can be removed and result passed directly to GST_DEBUG_OBJECT. > Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:496 > if (!caps || !stream->parent) { We need to fix the GST_ERROR bellow this line or it would be misleading :) Looks fine. Aniway, I'd give a run to the YouTube MSE tests[1] to look for regressions. [1] http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2018.html (In reply to Enrique Ocaña from comment #5) > Looks fine. Aniway, I'd give a run to the YouTube MSE tests[1] to look for > regressions. > > [1] > http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2018.html Do you mean with downstream? If so, can you check it? With trunk, even without this patch there's quite a few timeouts in the 2018 test-suite, #18, #20, 21, 22, 23, 30, 35, 36, 38, 39, 40, 41, 42 and then I had to stop because this takes ages :) LGTM. Committed r235109: <https://trac.webkit.org/changeset/235109> |