| Summary: | [Curl] Bug fix on deleting cookies when Max-Age is set to zero. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||
| Component: | Platform | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, Basuke.Suzuki, commit-queue, darin, ews-watchlist, galpeter, Hironori.Fujii, pvollan, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Basuke Suzuki
2018-08-15 13:44:54 PDT
Created attachment 347206 [details]
PATCH
Comment on attachment 347206 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=347206&action=review > Source/WebCore/platform/network/curl/CookieJarDB.cpp:352 > + if (!cookie.session && expires <= ::time(0)) There are better ways of getting the current time in WebCore, like MonotonicTime::now Comment on attachment 347206 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=347206&action=review >> Source/WebCore/platform/network/curl/CookieJarDB.cpp:352 >> + if (!cookie.session && expires <= ::time(0)) > > There are better ways of getting the current time in WebCore, like MonotonicTime::now Alright. Thanks! Created attachment 347326 [details]
fix
Comment on attachment 347326 [details] fix Clearing flags on attachment: 347326 Committed r234973: <https://trac.webkit.org/changeset/234973> All reviewed patches have been landed. Closing bug. |