| Summary: | Remove unused CSSPrimitiveValue::createAllowingMarginQuirk | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED CONFIGURATION CHANGED | ||||||||||||
| Severity: | Normal | CC: | ahmad.saleem792, ews-watchlist, joepeck, rniwa | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2018-08-15 09:38:52 PDT
Created attachment 347169 [details]
Patch
Created attachment 347186 [details]
Patch
Comment on attachment 347186 [details] Patch Attachment 347186 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8870543 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html Created attachment 347199 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 347267 [details]
Patch
Comment on attachment 347267 [details]
Patch
Nice! r=me
This commit: https://github.com/WebKit/WebKit/commit/eb7fc1ad354884881ab821955893b756ff55f14 Addressed both concern, which this patch was trying to resolve: * css/CSSPrimitiveValue.h: Remove unused createAllowingMarginQuirk function and the FIXME-NEWPARSER that said we wouldn't need it any more and the no-longer-needed isQuirkValue function. * css/CSSValue.h: Remove m_isQuirkValue. I am going to mark this as "RESOLVED CONFIGURATION CHANGED". Thanks! |