Bug 188596

Summary: [Attachment SPI] Remove attachment display mode options
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, mitz, sam, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Wenson Hsieh 2018-08-14 20:52:43 PDT 
Remove attachment display mode options, since r227068 offers a more suitable alternative for the purposes of Mail.
Comment 1 Wenson Hsieh 2018-08-14 21:17:49 PDT 
Created attachment 347147 [details]
Patch
Comment 2 Wenson Hsieh 2018-08-14 21:20:41 PDT 
Comment on attachment 347147 [details]
Patch

Oops, this actually won't work — Mail still sets mode to _WKAttachmentDisplayModeAsIcon.
Comment 3 Wenson Hsieh 2018-08-14 21:26:52 PDT 
Created attachment 347148 [details]
Patch
Comment 4 WebKit Commit Bot 2018-08-15 07:26:13 PDT 
Comment on attachment 347148 [details]
Patch

Clearing flags on attachment: 347148

Committed r234885: <https://trac.webkit.org/changeset/234885>
Comment 5 WebKit Commit Bot 2018-08-15 07:26:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-15 07:27:14 PDT 
<rdar://problem/43332450>