Bug 188594

Summary: Web Inspector: REGRESSION(r?): the probe sidebar doesn't show up when adding probes
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Devin Rousso 2018-08-14 18:18:09 PDT 
STEPS TO REPRODUCE:
1. Add a breakpoint
2. Right click and "Edit Breakpoint"
3. "Add Action" to "Probe Expression"
4. Put `this` in the input field that appears

Expected:
the "Probe" details sidebar appears with an entry for `this`

Actual:
there is no "Probe" sidebar, and it will cause WebInspector to crash

Notes:
This was most likely a regression caused by r217749 <https://webkit.org/b/172381>, since the event listeners that are responsible for creating the DOM elements for each probe are now only added after `initialLayout`, meaning that if the sidebar is successfully shown (after calling `inspect`), it will try to add elements that don't yet exist.
Comment 1 Devin Rousso 2018-08-14 18:23:47 PDT 
Created attachment 347140 [details]
Patch
Comment 2 BJ Burg 2018-08-15 09:57:39 PDT 
Comment on attachment 347140 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-08-15 10:29:21 PDT 
Comment on attachment 347140 [details]
Patch

Clearing flags on attachment: 347140

Committed r234889: <https://trac.webkit.org/changeset/234889>
Comment 4 WebKit Commit Bot 2018-08-15 10:29:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-15 10:30:22 PDT 
<rdar://problem/43339187>