Bug 188593

Summary:

Web Inspector: Table should not center rows when scrolling them into view

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Video] Table scrolling - before	none
[Video] Table scrolling - after	none
Patch	none

Description Matt Baker 2018-08-14 17:26:22 PDT

Using up/down arrow keys to scroll the table selection causes the row selection to jump around. Set opt_center false when calling Element.scrollIntoViewIfNeeded.

Comment 1 Radar WebKit Bug Importer 2018-08-14 17:32:14 PDT

<rdar://problem/43311660>

Comment 2 Matt Baker 2018-08-14 17:33:11 PDT

Created attachment 347136 [details]
[Video] Table scrolling - before

Comment 3 Matt Baker 2018-08-14 17:33:34 PDT

Created attachment 347137 [details]
[Video] Table scrolling - after

Comment 4 Matt Baker 2018-08-14 17:36:08 PDT

Created attachment 347139 [details]
Patch

Comment 5 Devin Rousso 2018-08-14 22:14:49 PDT

Comment on attachment 347139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347139&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Table.js:1176
> +            row.scrollIntoViewIfNeeded(false);

Looks like this might be dropped in favor of `Element.scrollIntoView()` at some point in the future.  We might have to change it then.

Comment 6 WebKit Commit Bot 2018-08-14 23:10:41 PDT

Comment on attachment 347139 [details]
Patch

Clearing flags on attachment: 347139

Committed r234882: <https://trac.webkit.org/changeset/234882>

Comment 7 WebKit Commit Bot 2018-08-14 23:10:42 PDT

All reviewed patches have been landed.  Closing bug.