| Summary: | [macOS] [WK2] Add infrastructure to test receiving file promises on drop | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | Tools / Tests | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, bdakin, commit-queue, ews-watchlist, lforschler, megan_gardner, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2018-08-14 15:47:25 PDT
Created attachment 347129 [details]
Patch
Comment on attachment 347129 [details] Patch Attachment 347129 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8886279 New failing tests: imported/blink/transitions/unprefixed-transform.html Created attachment 347328 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 347129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347129&action=review I'm not sure your unique filename finding logic in copyFile() is correct, but otherwise looks great! r=me > Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:48 > + _promisedTypeIdentifiers = adoptNS(promisedTypeIdentifiers.copy); I don't think dot syntax makes sense for -copy. It's an operation, not a property. > Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:101 > + NSString *adjustedFileName = suffix ? fileNameWithNumericSuffix(fileName, suffix) : fileName; Won't this try to copy to the same existing file path twice before appending a numeric suffix? Comment on attachment 347129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347129&action=review Thanks for the review! >> Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:48 >> + _promisedTypeIdentifiers = adoptNS(promisedTypeIdentifiers.copy); > > I don't think dot syntax makes sense for -copy. It's an operation, not a property. Sounds good — changed to [] notation. >> Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:101 >> + NSString *adjustedFileName = suffix ? fileNameWithNumericSuffix(fileName, suffix) : fileName; > > Won't this try to copy to the same existing file path twice before appending a numeric suffix? Ah, good catch! Fixed. Created attachment 347347 [details]
Patch for landing
Comment on attachment 347347 [details] Patch for landing Clearing flags on attachment: 347347 Committed r234976: <https://trac.webkit.org/changeset/234976> |