Bug 188580

Summary: LayoutTest inspector/worker/debugger-pause.html sometimes times out
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=164833
https://bugs.webkit.org/show_bug.cgi?id=206285
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2018-08-14 14:30:00 PDT 
LayoutTest inspector/worker/debugger-pause.html sometimes times out

See bug 164833.

> Test History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fworker%2Fdebugger-pause.html

I'll create an event for when the worker's main resource gets set.
Comment 1 Joseph Pecoraro 2018-08-14 15:10:45 PDT 
Created attachment 347115 [details]
[PATCH] Proposed Fix
Comment 2 Matt Baker 2018-08-14 16:01:26 PDT 
Comment on attachment 347115 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=347115&action=review

r=me

> Source/WebInspectorUI/UserInterface/Protocol/Target.js:79
> +        this.dispatchEventToListeners(WI.Target.Event.MainResourceAdded, {resource});

Nit: I wouldn't bother including data for the event. A listener can just query Target.mainResource if needed.
Comment 3 WebKit Commit Bot 2018-08-16 11:41:36 PDT 
Comment on attachment 347115 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 347115

Committed r234945: <https://trac.webkit.org/changeset/234945>
Comment 4 WebKit Commit Bot 2018-08-16 11:41:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-16 11:42:21 PDT 
<rdar://problem/43390767>