| Summary: | Fix exception throwing code so that topCallFrame and topEntryFrame stay true to their names. | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||||||||||||||||||||||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, rniwa, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||
|
Description
Mark Lam
2018-08-14 14:02:58 PDT
Created attachment 347320 [details]
proposed patch.
Created attachment 347321 [details]
x86_64 benchmark results on a 13" MBP.
I forgot to say: see the ChangeLog in the patch for details of what change is being proposed and why. Comment on attachment 347320 [details] proposed patch. Attachment 347320 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8886568 New failing tests: http/tests/misc/large-js-program.php Created attachment 347329 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347320 [details] proposed patch. Attachment 347320 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/8886517 New failing tests: stress/regress-188577.js.no-ftl stress/regress-188577.js.dfg-eager-no-cjit-validate stress/regress-188577.js.ftl-eager-no-cjit stress/regress-188577.js.ftl-eager-no-cjit-b3o1 stress/regress-188577.js.ftl-no-cjit-b3o1 stress/regress-188577.js.ftl-no-cjit-small-pool stress/regress-188577.js.default stress/regress-188577.js.no-cjit-validate-phases stress/regress-188577.js.ftl-no-cjit-no-inline-validate stress/regress-188577.js.dfg-eager stress/regress-188577.js.no-cjit-collect-continuously stress/regress-188577.js.ftl-no-cjit-no-put-stack-validate stress/regress-188577.js.ftl-no-cjit-validate-sampling-profiler stress/regress-188577.js.ftl-eager stress/regress-188577.js.dfg-maximal-flush-validate-no-cjit apiTests Comment on attachment 347320 [details] proposed patch. Attachment 347320 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8886583 New failing tests: http/tests/misc/large-js-program.php Created attachment 347330 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 347320 [details] proposed patch. Attachment 347320 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8886624 New failing tests: http/tests/misc/large-js-program.php Created attachment 347332 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347320 [details]
proposed patch.
Need to investigate test failures to see what bug crept in.
Created attachment 347364 [details]
patch for EWS testing.
I can't repro the JSC test failure locally. Let's try a test tweak on the EWS.
Comment on attachment 347364 [details] patch for EWS testing. Attachment 347364 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8892901 New failing tests: http/tests/misc/large-js-program.php Created attachment 347370 [details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347364 [details] patch for EWS testing. Attachment 347364 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/8892747 New failing tests: stress/regress-188577.js.no-ftl stress/regress-188577.js.dfg-eager-no-cjit-validate stress/regress-188577.js.ftl-eager-no-cjit stress/regress-188577.js.ftl-eager-no-cjit-b3o1 stress/regress-188577.js.ftl-no-cjit-b3o1 stress/regress-188577.js.ftl-no-cjit-small-pool stress/regress-188577.js.default stress/regress-188577.js.no-cjit-validate-phases stress/regress-188577.js.ftl-no-cjit-no-inline-validate stress/regress-188577.js.dfg-eager stress/regress-188577.js.no-cjit-collect-continuously stress/regress-188577.js.ftl-no-cjit-no-put-stack-validate stress/regress-188577.js.ftl-no-cjit-validate-sampling-profiler stress/regress-188577.js.ftl-eager stress/regress-188577.js.dfg-maximal-flush-validate-no-cjit apiTests Comment on attachment 347364 [details] patch for EWS testing. Attachment 347364 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8892916 New failing tests: http/tests/misc/large-js-program.php Created attachment 347372 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 347523 [details]
candidate patch for EWS testing.
Attachment 347523 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/interpreter/CallFrame.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/runtime/VM.h:302: The parameter name "callFrame" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 32 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347523 [details] candidate patch for EWS testing. Attachment 347523 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/8920366 New failing tests: stress/regress-188577.js.no-ftl stress/regress-188577.js.dfg-eager-no-cjit-validate stress/regress-188577.js.ftl-eager-no-cjit stress/regress-188577.js.ftl-eager-no-cjit-b3o1 stress/regress-188577.js.ftl-no-cjit-b3o1 stress/regress-188577.js.ftl-no-cjit-small-pool stress/regress-188577.js.default stress/regress-188577.js.no-cjit-validate-phases stress/regress-188577.js.ftl-no-cjit-no-inline-validate stress/regress-188577.js.dfg-eager stress/regress-188577.js.no-cjit-collect-continuously stress/regress-188577.js.ftl-no-cjit-no-put-stack-validate stress/regress-188577.js.ftl-no-cjit-validate-sampling-profiler stress/regress-188577.js.ftl-eager stress/regress-188577.js.dfg-maximal-flush-validate-no-cjit apiTests Comment on attachment 347523 [details] candidate patch for EWS testing. Attachment 347523 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8920754 New failing tests: http/tests/misc/large-js-program.php Created attachment 347542 [details]
Archive of layout-test-results from ews117 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 347574 [details]
patch for EWS testing.
Attachment 347574 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/interpreter/CallFrame.cpp:190: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/interpreter/CallFrame.cpp:191: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/interpreter/CallFrame.cpp:203: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/interpreter/CallFrame.cpp:205: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/interpreter/CallFrame.cpp:206: Should have a space between // and comment [whitespace/comments] [4]
ERROR: Source/JavaScriptCore/interpreter/CallFrame.cpp:216: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 6 in 52 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347574 [details] patch for EWS testing. Attachment 347574 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/8925162 New failing tests: stress/regress-188577.js.no-ftl stress/regress-188577.js.dfg-eager-no-cjit-validate stress/regress-188577.js.ftl-eager-no-cjit stress/regress-188577.js.ftl-eager-no-cjit-b3o1 stress/regress-188577.js.ftl-no-cjit-b3o1 stress/regress-188577.js.ftl-no-cjit-small-pool stress/regress-188577.js.default stress/regress-188577.js.no-cjit-validate-phases stress/regress-188577.js.ftl-no-cjit-no-inline-validate stress/regress-188577.js.dfg-eager stress/regress-188577.js.no-cjit-collect-continuously stress/regress-188577.js.ftl-no-cjit-no-put-stack-validate stress/regress-188577.js.ftl-no-cjit-validate-sampling-profiler stress/regress-188577.js.ftl-eager stress/regress-188577.js.dfg-maximal-flush-validate-no-cjit apiTests Comment on attachment 347574 [details] patch for EWS testing. Attachment 347574 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8925122 New failing tests: http/tests/misc/large-js-program.php Created attachment 347604 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 348021 [details]
patch for EWS testing.
Created attachment 348047 [details]
proposed patch.
Let's get some EWS testing first.
Comment on attachment 348047 [details] proposed patch. Attachment 348047 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8976352 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html Created attachment 348059 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 348047 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=348047&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:314 > loadp VM::callFrameForCatch[t3], cfr this LOC can now be removed. Thanks for the review. (In reply to Build Bot from comment #31) > New failing tests: > css3/filters/backdrop/add-remove-add-backdrop-filter.html FYI, this test failure is unrelated. It's an image diff which has nothing to do with this patch. (In reply to Saam Barati from comment #33) > > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:314 > > loadp VM::callFrameForCatch[t3], cfr > > this LOC can now be removed. I've removed this dead code both in LowLevelInterpreter32_64.asm and LowLevelInterpreter64.asm. Landed in r235419: <http://trac.webkit.org/r235419>. |