| Summary: | [YARR] Align allocation size in BumpPointerAllocator with sizeof(void*) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | don.olmstead, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2018-08-14 11:52:05 PDT
Created attachment 347100 [details]
Patch
Comment on attachment 347100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347100&action=review > Source/JavaScriptCore/yarr/YarrInterpreter.cpp:77 > + static size_t allocationSize(size_t numberOfFrames) Should we be worried about overflow here? > Source/JavaScriptCore/yarr/YarrInterpreter.cpp:133 > + static size_t allocationSize(size_t numberOfSubpatterns) Ditto Comment on attachment 347100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347100&action=review Thank you! >> Source/JavaScriptCore/yarr/YarrInterpreter.cpp:77 >> + static size_t allocationSize(size_t numberOfFrames) > > Should we be worried about overflow here? Use Checked<> here. >> Source/JavaScriptCore/yarr/YarrInterpreter.cpp:133 >> + static size_t allocationSize(size_t numberOfSubpatterns) > > Ditto Fixed by using Checked<> Committed r234916: <https://trac.webkit.org/changeset/234916> |