| Summary: | Clean up CSSSelectorList after r234825 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, megan_gardner, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2018-08-14 11:17:14 PDT
Created attachment 347095 [details]
Patch
Created attachment 347188 [details]
Patch
Comment on attachment 347188 [details] Patch Attachment 347188 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8878152 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html Created attachment 347254 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 347188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347188&action=review Assuming the win failure isn't an issue, and it's really fine to remove the deleteSelectors definition. r=me > Source/WebCore/css/CSSSelectorList.h:-73 > - It's not clear to me why this is being removed. > Source/WebCore/css/StyleRule.cpp:222 > } Oh, these are being changed because they are now explicit? Comment on attachment 347188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347188&action=review >> Source/WebCore/css/CSSSelectorList.h:-73 >> - > > It's not clear to me why this is being removed. It's an unused declaration. There's no definition. Ah, I didn't realize this was deleted in the previous patch. Comment on attachment 347188 [details] Patch Clearing flags on attachment: 347188 Committed r235002: <https://trac.webkit.org/changeset/235002> All reviewed patches have been landed. Closing bug. |