Bug 188565

Summary: [Curl] Implement platform default timeout interval.
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: PlatformAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, Basuke.Suzuki, commit-queue, darin, ews-watchlist, galpeter, Hironori.Fujii, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=162484
Attachments:
Description Flags
PATCH
none
PATCH
none
PATCH
achristensen: review+, achristensen: commit-queue-
PATCH none

Description Basuke Suzuki 2018-08-14 11:13:19 PDT 
Curl port didn't implement platform default timeout interval. It treated zero value for timeout interval as no timeout.

Caught by this test:
 * http/tests/xmlhttprequest/on-network-timeout-error-during-preflight.html
Comment 1 Basuke Suzuki 2018-08-14 14:11:57 PDT 
Created attachment 347108 [details]
PATCH
Comment 2 EWS Watchlist 2018-08-14 14:13:17 PDT 
Attachment 347108 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Basuke Suzuki 2018-08-14 14:29:45 PDT 
Created attachment 347111 [details]
PATCH

Fix ChangeLog style
Comment 4 EWS Watchlist 2018-08-14 14:31:31 PDT 
Attachment 347111 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Basuke Suzuki 2018-08-14 14:48:03 PDT 
Created attachment 347112 [details]
PATCH
Comment 6 Alex Christensen 2018-08-14 15:02:07 PDT 
Comment on attachment 347112 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=347112&action=review

> Source/WebCore/platform/network/curl/CurlContext.cpp:610
> +    // CURLOPT_LOW_SPEED_LIMIT is used instead. It enables the spped watcher

speed
Comment 7 Basuke Suzuki 2018-08-14 15:36:17 PDT 
Created attachment 347117 [details]
PATCH

Alex, thanks for r+
Comment 8 WebKit Commit Bot 2018-08-14 16:17:21 PDT 
Comment on attachment 347117 [details]
PATCH

Clearing flags on attachment: 347117

Committed r234864: <https://trac.webkit.org/changeset/234864>
Comment 9 WebKit Commit Bot 2018-08-14 16:17:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-08-14 16:18:19 PDT 
<rdar://problem/43308768>