| Summary: | [JSC] GetByIdStatus::m_wasSeenInJIT is touched in GetByIdStatus::slowVersion | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | don.olmstead, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2018-08-14 10:35:41 PDT
Created attachment 347089 [details]
Patch
Informal review r+. This was also detected with a UBSan run of ARES6. This one looks like it might've been caught with clang's linter if we ran that as well. Comment on attachment 347089 [details]
Patch
Ugh, I wish there was a way we could get a compiler warning about members without default constructors not being initialized...
(In reply to Keith Miller from comment #3) > Comment on attachment 347089 [details] > Patch > > Ugh, I wish there was a way we could get a compiler warning about members > without default constructors not being initialized... Yeah, this case is a bit complicated. And it is awesome that UBSan catches this. (In reply to Don Olmstead from comment #2) > Informal review r+. This was also detected with a UBSan run of ARES6. > > This one looks like it might've been caught with clang's linter if we ran > that as well. Nice! Committed r234855: <https://trac.webkit.org/changeset/234855> |