| Summary: | [DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2018-08-14 09:43:58 PDT
Created attachment 347082 [details]
Patch
Comment on attachment 347082 [details]
Patch
r=me. Should we also specify an initializer for m_pass { PrimaryPass } (just to be pedantic)?
(In reply to Mark Lam from comment #2) > Comment on attachment 347082 [details] > Patch > > r=me. Should we also specify an initializer for m_pass { PrimaryPass } > (just to be pedantic)? It sounds nice. I would like to keep both (initializer and `m_pass = PrimaryPass`). Since the latter offers good readability of PredictionPropagationPhase::run function. Committed r234853: <https://trac.webkit.org/changeset/234853> |