| Summary: | [LFC][Floating] Add support for negative clearance. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2018-08-14 08:55:16 PDT
Created attachment 347079 [details]
Patch
Comment on attachment 347079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347079&action=review > Source/WebCore/layout/FloatingContext.cpp:155 > + auto absoluteTop = FormattingContext::mapTopLeftToAncestor(layoutContext, layoutBox, downcast<Container>(m_floatingState.root())).y; Maybe don't call this absolute. > Source/WebCore/layout/FloatingContext.cpp:164 > + // Previous inlflow's bottom margin is collapsed. inlflow's Maybe explain the assertion better, like "Previous inflow sibling has been laid out already, so it's bottom margin will have been collapsed". > Source/WebCore/layout/FloatingContext.cpp:168 > + // Reset previous's bottom and current's top to non-collapsing. Say previous box Committed r234878: <https://trac.webkit.org/changeset/234878> |