| Summary: | [GStreamer][GL] useless ifdef in pushTextureToCompositor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
| Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | calvaris, magomez, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Philippe Normand
2018-08-14 06:11:17 PDT
Created attachment 347070 [details]
Patch
Comment on attachment 347070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347070&action=review I think it is ok. Anyway, I'd wait until somebody like Miguel has a look at it as well. > Source/WebCore/ChangeLog:10 > + There's no need for a ifdef because the frame holder already Nit: I think it is aN ifdef > Source/WebCore/ChangeLog:11 > + ensures a valid texture ID will set if it maps a GL video frame. will BE set? Looks good to me. Committed r235543: <https://trac.webkit.org/changeset/235543> |