| Summary: | [ews-build] Allow * as platform for builders and workers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, ews-watchlist, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2018-08-13 14:43:21 PDT
Created attachment 347042 [details]
Proposed patch
Comment on attachment 347042 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=347042&action=review > Tools/BuildSlaveSupport/ews-build/loadConfig.py:162 > + if worker['platform'] != builder['platform'] and worker['platform'] != '*' and builder['platform'] != '*': I'm not sure what our supported configurations might be, so my initial thought is to break this logic... Is it possible we would have a configuration where either worker['platform'] was * OR builder['platform'] = * but not both? In that case, would we prefer to do something like and (worker['platform'] != '*' or builder['platform'] != '*') Comment on attachment 347042 [details] Proposed patch Attachment 347042 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8882931 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html http/tests/security/local-video-source-from-remote.html Created attachment 347291 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
> > Tools/BuildSlaveSupport/ews-build/loadConfig.py:162 > > + if worker['platform'] != builder['platform'] and worker['platform'] != '*' and builder['platform'] != '*': > > I'm not sure what our supported configurations might be, so my initial thought is to break this logic... > > Is it possible we would have a configuration where either worker['platform'] was * OR builder['platform'] = * but not both? Yes, Recently I have been using such a configuration on https://ews-build.webkit-uat.org, especially because I have limited bots for testing and I want a bot to process builds from multiple queues (both mac and ios). In this case worker['platform'] is * since worker can connect to multiple queues. builder['platform'] remains ios/mac accordingly. e.g.: https://bugs.webkit.org/show_bug.cgi?id=194304 > In that case, would we prefer to do something like > and (worker['platform'] != '*' or builder['platform'] != '*') This 'if' is to detect an error case, so it should be 'and' of all three conditions. The one in the patch has been working fine in my testing for a while. Comment on attachment 347042 [details] Proposed patch Clearing flags on attachment: 347042 Committed r240999: <https://trac.webkit.org/changeset/240999> All reviewed patches have been landed. Closing bug. |