| Summary: | [MotionMark] Update Leaves test | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||||
| Component: | Animations | Assignee: | Jon Lee <jonlee> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, dino, ews-watchlist, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jon Lee
2018-08-13 14:20:44 PDT
Created attachment 347036 [details]
Patch
Created attachment 347037 [details]
Patch
Comment on attachment 347037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347037&action=review > PerformanceTests/MotionMark/tests/master/resources/leaves.js:85 > + this.element.style.opacity = this._opacity; The use of this._opacity is be guarded by this.usesOpacity unless this._opacity is always initialized with the default value. But I do not see that. Comment on attachment 347037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347037&action=review >> PerformanceTests/MotionMark/tests/master/resources/leaves.js:85 >> + this.element.style.opacity = this._opacity; > > The use of this._opacity is be guarded by this.usesOpacity unless this._opacity is always initialized with the default value. But I do not see that. Good point. It turns out that all of the subclasses do override the method. I'll fix this in the next version. Comment on attachment 347037 [details] Patch Clearing flags on attachment: 347037 Committed r234823: <https://trac.webkit.org/changeset/234823> All reviewed patches have been landed. Closing bug. |