Bug 188525

Summary: Added Thomas Denney to contributors.json.
Product: WebKit Reporter: Thomas Denney <tdenney>
Component: New BugsAssignee: Thomas Denney <tdenney>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 188536    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Thomas Denney 2018-08-13 12:07:13 PDT 
Added Thomas Denney to contributors.json.
Comment 1 Thomas Denney 2018-08-13 12:07:35 PDT 
Created attachment 347024 [details]
Patch
Comment 2 EWS Watchlist 2018-08-13 12:10:06 PDT 
Attachment 347024 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-08-13 12:52:20 PDT 
Comment on attachment 347024 [details]
Patch

Clearing flags on attachment: 347024

Committed r234812: <https://trac.webkit.org/changeset/234812>
Comment 4 WebKit Commit Bot 2018-08-13 12:52:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-13 12:53:22 PDT 
<rdar://problem/43247745>
Comment 6 Thomas Denney 2018-08-13 14:37:19 PDT 
Need to remove the line with contributor on.
Comment 7 Thomas Denney 2018-08-13 14:38:49 PDT 
Created attachment 347040 [details]
Patch
Comment 8 EWS Watchlist 2018-08-13 14:41:25 PDT 
Attachment 347040 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Thomas Denney 2018-08-13 16:57:47 PDT 
Created attachment 347055 [details]
Patch
Comment 10 EWS Watchlist 2018-08-13 16:59:51 PDT 
Attachment 347055 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 WebKit Commit Bot 2018-08-20 12:22:32 PDT 
Comment on attachment 347055 [details]
Patch

Clearing flags on attachment: 347055

Committed r235089: <https://trac.webkit.org/changeset/235089>
Comment 12 WebKit Commit Bot 2018-08-20 12:22:34 PDT 
All reviewed patches have been landed.  Closing bug.