Bug 188525

Summary: Added Thomas Denney to contributors.json.
Product: WebKit Reporter: Thomas Denney <tdenney>
Component: New BugsAssignee: Thomas Denney <tdenney>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 188536    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Thomas Denney
Reported 2018-08-13 12:07:13 PDT
Added Thomas Denney to contributors.json.
Attachments
Patch (1.36 KB, patch)
2018-08-13 12:07 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2018-08-13 14:38 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Patch (1.31 KB, patch)
2018-08-13 16:57 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Thomas Denney
Comment 1 2018-08-13 12:07:35 PDT
Created attachment 347024 [details] Patch
EWS Watchlist
Comment 2 2018-08-13 12:10:06 PDT
Attachment 347024 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2018-08-13 12:52:20 PDT
Comment on attachment 347024 [details] Patch Clearing flags on attachment: 347024 Committed r234812: <https://trac.webkit.org/changeset/234812>
WebKit Commit Bot
Comment 4 2018-08-13 12:52:21 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-08-13 12:53:22 PDT
<rdar://problem/43247745>
Thomas Denney
Comment 6 2018-08-13 14:37:19 PDT
Need to remove the line with contributor on.
Thomas Denney
Comment 7 2018-08-13 14:38:49 PDT
Created attachment 347040 [details] Patch
EWS Watchlist
Comment 8 2018-08-13 14:41:25 PDT
Attachment 347040 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Thomas Denney
Comment 9 2018-08-13 16:57:47 PDT
Created attachment 347055 [details] Patch
EWS Watchlist
Comment 10 2018-08-13 16:59:51 PDT
Attachment 347055 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 11 2018-08-20 12:22:32 PDT
Comment on attachment 347055 [details] Patch Clearing flags on attachment: 347055 Committed r235089: <https://trac.webkit.org/changeset/235089>
WebKit Commit Bot
Comment 12 2018-08-20 12:22:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.