Bug 188478

Summary: [Cocoa] WebKit::PlatformPopupMenuData should use member initialization
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, joepeck, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2018-08-10 13:35:55 PDT 
WebKit::PlatformPopupMenuData should use member initialization.

A new checker for the clang static analyzer found that the default constructor doesn't initialize these member fields to default values.
Comment 1 Radar WebKit Bug Importer 2018-08-10 13:36:12 PDT 
<rdar://problem/43154363>
Comment 2 David Kilzer (:ddkilzer) 2018-08-10 13:47:38 PDT 
Created attachment 346919 [details]
Patch v1
Comment 3 Joseph Pecoraro 2018-08-10 13:50:15 PDT 
Comment on attachment 346919 [details]
Patch v1

r=me
Comment 4 Joseph Pecoraro 2018-08-10 13:50:42 PDT 
Comment on attachment 346919 [details]
Patch v1

Leaving `cq?` until bots finish running.
Comment 5 WebKit Commit Bot 2018-08-10 19:55:30 PDT 
Comment on attachment 346919 [details]
Patch v1

Clearing flags on attachment: 346919

Committed r234781: <https://trac.webkit.org/changeset/234781>
Comment 6 WebKit Commit Bot 2018-08-10 19:55:31 PDT 
All reviewed patches have been landed.  Closing bug.