Bug 188469

Summary: [IntersectionObserver] Implement rootMargin parsing
Product: WebKit Reporter: Ali Juma <ajuma>
Component: Layout and RenderingAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, kondapallykalyan, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159475    
Attachments:
Description Flags
Patch
none
Follow-up fix none

Description Ali Juma 2018-08-10 07:00:57 PDT 
Parse the constructor's rootMargin argument and throw an exception if it's invalid.
Comment 1 Ali Juma 2018-08-10 07:17:16 PDT 
Created attachment 346903 [details]
Patch
Comment 2 WebKit Commit Bot 2018-08-10 10:08:50 PDT 
Comment on attachment 346903 [details]
Patch

Clearing flags on attachment: 346903

Committed r234761: <https://trac.webkit.org/changeset/234761>
Comment 3 WebKit Commit Bot 2018-08-10 10:08:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-10 10:09:19 PDT 
<rdar://problem/43146118>
Comment 5 Darin Adler 2018-08-14 09:33:25 PDT 
Comment on attachment 346903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346903&action=review

> Source/WebCore/page/IntersectionObserver.cpp:114
> +            stringBuilder.append("px", 2);

Oops, missed this in the initial review. This should instead be:

    stringBuilder.appendLiteral("px");
Comment 6 Ali Juma 2018-08-14 10:08:50 PDT 
Reopening to attach new patch.
Comment 7 Ali Juma 2018-08-14 10:08:52 PDT 
Created attachment 347087 [details]
Follow-up fix

Address review comment
Comment 8 Ali Juma 2018-08-14 10:12:22 PDT 
Comment on attachment 347087 [details]
Follow-up fix

Clearing flags on attachment: 347087

Committed r234851: <https://trac.webkit.org/changeset/234851>
Comment 9 Ali Juma 2018-08-14 10:12:24 PDT 
All reviewed patches have been landed.  Closing bug.