Bug 188443

Summary:

REGRESSION (r232083): WKWebView loses first-party cookies on iOS

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

New Bugs

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Sihui Liu 2018-08-09 10:39:03 PDT

For apps using shared cookie storage, cookies cannot be read from or written to persistent storage.

Comment 1 Sihui Liu 2018-08-09 10:43:41 PDT

<rdar://problem/42991584>

Comment 2 Sihui Liu 2018-08-09 10:48:11 PDT

Created attachment 346844 [details]
Patch

Comment 3 Chris Dumez 2018-08-09 10:49:47 PDT

Comment on attachment 346844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346844&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:480
> +#if (PLATFORM(MAC)

How does that even build? :)

Comment 4 Sihui Liu 2018-08-09 10:49:57 PDT

Created attachment 346845 [details]
Patch

Comment 5 Chris Dumez 2018-08-09 10:51:09 PDT

Also, please make sure locally that it fixes the issue from the radar.

Comment 6 Chris Dumez 2018-08-09 10:52:42 PDT

Comment on attachment 346845 [details]
Patch

r=me assuming the bots are happy and you confirm it fixes the bug.

Comment 7 Sihui Liu 2018-08-09 11:02:29 PDT

(In reply to Chris Dumez from comment #6)
> Comment on attachment 346845 [details]
> Patch
> 
> r=me assuming the bots are happy and you confirm it fixes the bug.

Verified. Waiting for all bots to be happy.

Comment 8 Chris Dumez 2018-08-09 11:48:18 PDT

Comment on attachment 346845 [details]
Patch

Clearing flags on attachment: 346845

Committed r234730: <https://trac.webkit.org/changeset/234730>

Comment 9 Chris Dumez 2018-08-09 11:48:20 PDT

All reviewed patches have been landed.  Closing bug.