Bug 188429

Summary: Prevent collectScreenProperties from crashing Base System
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Justin Fan 2018-08-08 19:21:38 PDT 
Prevent collectScreenProperties from crashing Base System
Comment 1 Radar WebKit Bug Importer 2018-08-08 19:25:48 PDT 
<rdar://problem/43075662>
Comment 2 Justin Fan 2018-08-08 19:50:39 PDT 
Created attachment 346812 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-08-08 19:57:21 PDT 
Comment on attachment 346812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346812&action=review

> Source/WebCore/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).

This should go above the description (use "webkit-patch upload" to prepare your patches).

> Source/WebCore/platform/mac/PlatformScreenMac.mm:203
> +    CGLRendererInfoObj rendererInfo = 0;

nullptr, not 0

> Source/WebCore/platform/mac/PlatformScreenMac.mm:205
>      ASSERT(error == kCGLNoError);

We know this assert will fire on some systems, so remove it.
Comment 4 Justin Fan 2018-08-08 20:06:52 PDT 
Created attachment 346814 [details]
Patch
Comment 5 Justin Fan 2018-08-08 20:09:52 PDT 
Thanks for the rapid review Simon!
Comment 6 WebKit Commit Bot 2018-08-08 20:53:25 PDT 
Comment on attachment 346814 [details]
Patch

Clearing flags on attachment: 346814

Committed r234717: <https://trac.webkit.org/changeset/234717>
Comment 7 WebKit Commit Bot 2018-08-08 20:53:26 PDT 
All reviewed patches have been landed.  Closing bug.