| Summary: | Disallow navigations when page cache updates the current document of the frame | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
| Component: | Page Loading | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, beidson, cdumez, ews-watchlist, japhet, koivisto, rniwa, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Bates
2018-08-08 15:34:30 PDT
Created attachment 346804 [details]
Patch and layout test
Comment on attachment 346804 [details] Patch and layout test View in context: https://bugs.webkit.org/attachment.cgi?id=346804&action=review > LayoutTests/fast/history/go-back-to-object-subframe.html:22 > +window.onpageshow = runTest; We should probably mention in the change log that we're not preventing navigation during pageshow event. (In reply to Ryosuke Niwa from comment #2) > Comment on attachment 346804 [details] > Patch and layout test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=346804&action=review > > > LayoutTests/fast/history/go-back-to-object-subframe.html:22 > > +window.onpageshow = runTest; > > We should probably mention in the change log that we're not preventing > navigation during pageshow event. Will add the following remark to the change log entry in LayoutTests/ChangeLog: This change does not prevent navigations initiated from a pageshow event handler. Committed r235121: <https://trac.webkit.org/changeset/235121> |