Bug 188416

Summary: Import WPTs for IntersectionObserver
Product: WebKit Reporter: Ali Juma <ajuma>
Component: Layout and RenderingAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159475    
Attachments:
Description Flags
Patch none

Ali Juma
Reported 2018-08-08 13:47:15 PDT
Import WPTs for IntersectionObserver
Attachments
Patch (119.42 KB, patch)
2018-08-08 13:53 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-08-08 13:53:30 PDT
Created attachment 346790 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-08-08 14:48:50 PDT
Comment on attachment 346790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346790&action=review > Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:580 > +- (void)setIntersectionObserverEnabled:(BOOL)flag; > +- (BOOL)intersectionObserverEnabled; I don't think you need this. You can to through the (admittedly bad) experimental features API. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:870 > + [preferences setIntersectionObserverEnabled:YES]; We really need to make this automatic. Sad that you have to do this.
Ali Juma
Comment 3 2018-08-08 14:59:03 PDT
Comment on attachment 346790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346790&action=review >> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:580 >> +- (BOOL)intersectionObserverEnabled; > > I don't think you need this. You can to through the (admittedly bad) experimental features API. This in WK1 (exposing the method that DumpRenderTree needs to call), so there's no experimental features API afaik.
WebKit Commit Bot
Comment 4 2018-08-09 06:36:58 PDT
Comment on attachment 346790 [details] Patch Clearing flags on attachment: 346790 Committed r234723: <https://trac.webkit.org/changeset/234723>
WebKit Commit Bot
Comment 5 2018-08-09 06:36:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-09 06:37:30 PDT
<rdar://problem/43092053>
Note You need to log in before you can comment on or make changes to this bug.