Bug 188408

We should probably not try to use GTK+ theme for checkboxes that are this small. Carlos Eduardo, what do you think?

(In reply to Michael Catanzaro from comment #1) > We should probably not try to use GTK+ theme for checkboxes that are this > small. > > Carlos Eduardo, what do you think? Hi Michael! I took a look at this on Friday but didn't have time to comment here. Yes, this is another problem with GTK+ theme rendering bigger areas than the page style asks for. In the inspector the mentioned checkbox is 10x10, but GTK+ minimumSize() is 24x16. It's one of the things in the way in a patch I was writing on the spinbuttons too. It's in a sensible area (RenderThemeGadget::render()) that could cause lots of regressions or tests needed to be rebased. I tried to not draw with GTK+ (using RenderThemeGtk::isControlStyled()) but then the engine simply does not draw any checkbox at all. Not good. I'm trying to come up with a good solution but at a first glance I couldn't find how to solve it trivially.

(In reply to Carlos Eduardo Ramalho from comment #2) > I tried to not draw with GTK+ (using RenderThemeGtk::isControlStyled()) but > then the engine simply does not draw any checkbox at all. Not good. Hm, there should be a fallback style (used e.g. for WPE)

(In reply to Michael Catanzaro from comment #3) > Hm, there should be a fallback style (used e.g. for WPE) WPE uses a different Theme API (guarded by USE(NEW_THEME)), where drawing of widgets is done directly via GraphicsContext calls. Hence no need for a widget library. This code is in WebCore/platform/wpe/ThemeWPE.cpp I was thinking of migrating the GTK theme to this new model to enable threaded painting in WebKitGTK+ (see discussion in bug 186840) but it's a lot of work... Not sure if it's the best thing to do in the long-term. Currently Mac and WPE ports use NEW_THEME. What do you think about this, Carlos Garcia? Not sure if this discussion should be placed in this bug.. If a follow-up discussion is worth I could open another bug.

(In reply to Michael Catanzaro from comment #3) > Hm, there should be a fallback style (used e.g. for WPE) WPE uses a different Theme API (guarded by USE(NEW_THEME)), where drawing of widgets is done directly via GraphicsContext calls. Hence no need for a widget library. This code is in WebCore/platform/wpe/ThemeWPE.cpp I was thinking of migrating the GTK theme to this new model to enable threaded painting in WebKitGTK+ (see discussion in bug 186840) but it's a lot of work... Not sure if it's the best thing to do in the long-term. Currently Mac and WPE ports use NEW_THEME. What do you think about this, Carlos Garcia? Not sure if this discussion should be placed in this bug.. If a follow-up discussion is worth I could open another bug.

(In reply to Carlos Eduardo Ramalho from comment #5) > (In reply to Michael Catanzaro from comment #3) > > Hm, there should be a fallback style (used e.g. for WPE) > > WPE uses a different Theme API (guarded by USE(NEW_THEME)), where drawing of > widgets is done directly via GraphicsContext calls. Hence no need for a > widget library. This code is in WebCore/platform/wpe/ThemeWPE.cpp I don't think NEW_THEME imposes to use graphics context, it's the same with the other path, we get a graphics context too. The problem is that the GTK+ theme api renders in a cairo context that we get from the graphics context. > I was thinking of migrating the GTK theme to this new model to enable > threaded painting in WebKitGTK+ (see discussion in bug 186840) but it's a > lot of work... Not sure if it's the best thing to do in the long-term. > Currently Mac and WPE ports use NEW_THEME. > > What do you think about this, Carlos Garcia? I don't understand how using NEW_THEME would allow us to enable threaded painting. Could you elaborate? > Not sure if this discussion should be placed in this bug.. If a follow-up > discussion is worth I could open another bug.

Created attachment 353035 [details] Screenshot of checkbox clickable area and visible position Added another attachment which shows the clickable area (shown in white) only partially overlaps the place where the checkbox is drawn. This means that a part of the visible checkbox does not toggle the checkbox when clicked. Select some text around the checkbox to reproduce the screenshot.