| Summary: | [Nicosia] Add the Nicosia-specific PlatformLayer type alias | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cgarcia, cmarcelo, commit-queue, dino, don.olmstead, ews-watchlist, graouts, kondapallykalyan, luiz, magomez, noam, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 187385 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Zan Dobersek
2018-08-08 00:48:15 PDT
Created attachment 346759 [details]
Patch
Attachment 346759 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:857: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 346759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346759&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:777 > + [&](TextureMapperPlatformLayerProxy& proxy) Do we really need to capture everything? I prefer explicit capture and I guess 'this' is the only thing we need to capture here, no? Created attachment 346761 [details]
Patch for landing
Comment on attachment 346761 [details] Patch for landing Clearing flags on attachment: 346761 Committed r234688: <https://trac.webkit.org/changeset/234688> All reviewed patches have been landed. Closing bug. Created attachment 346779 [details]
WinCairo build fix
An #ifdef guard around USE(NICOSIA) was missing.
This broke the WinCairo build Created attachment 346784 [details]
Build fix
Comment on attachment 346784 [details] Build fix Clearing flags on attachment: 346784 Committed r234710: <https://trac.webkit.org/changeset/234710> All reviewed patches have been landed. Closing bug. |