Bug 188403

Summary: [css-grid] Update behavior of percentage row tracks and gutters
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Layout and RenderingAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jfernandez, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=846187
Attachments:
Description Flags
Patch none

Description Manuel Rego Casasnovas 2018-08-07 22:29:20 PDT 
This bug is to adapt WebKit to the following resolutions by the CSSWG:
* Percentage row tracks: https://github.com/w3c/csswg-drafts/issues/1921
* Percentage row gutters: https://github.com/w3c/csswg-drafts/issues/509

The change has been already done in Blink (https://chromium.googlesource.com/chromium/src/+/47bfc59ccdda82e2b28817a653c792d7a606ee8e)
so it'd be nice to follow it in WebKit too.

Change for percentage row gutters has been also done in Firefox already.
Comment 1 Manuel Rego Casasnovas 2018-08-07 22:35:14 PDT 
Created attachment 346757 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2018-08-07 22:48:30 PDT 
Comment on attachment 346757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346757&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties.html:97
> +        '<track-size>.<track-breadth>.<percentage>': ['100%', '150px 50px 50px'],

Created PR in WPT for this change (as this was not in the repo yet):
https://github.com/web-platform-tests/wpt/pull/12349

Please review and merge the PR first before landing this patch.
Comment 3 Sergio Villar Senin 2018-08-08 00:27:02 PDT 
Comment on attachment 346757 [details]
Patch

Great stuff!
Comment 4 WebKit Commit Bot 2018-08-08 02:14:43 PDT 
Comment on attachment 346757 [details]
Patch

Clearing flags on attachment: 346757

Committed r234687: <https://trac.webkit.org/changeset/234687>
Comment 5 WebKit Commit Bot 2018-08-08 02:14:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-08 02:15:38 PDT 
<rdar://problem/43039111>