| Summary: | [macOS] Create a test for scrollbar visibility when 3rd party mouse is used. | ||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||||||||||||||||||||||||||||||
| Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||||||||||||||||||||||||||||||||||||
| Status: | NEW --- | ||||||||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, ews-watchlist, lforschler, rniwa, sam, simon.fraser, webkit-bug-importer | ||||||||||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||
|
Description
Per Arne Vollan
2018-08-07 08:51:42 PDT
Created attachment 347852 [details]
Patch
Created attachment 347853 [details]
Patch
Created attachment 347857 [details]
Patch
Created attachment 347864 [details]
Patch
Created attachment 347865 [details]
Patch
Created attachment 347867 [details]
Patch
Created attachment 347874 [details]
Patch
Comment on attachment 347874 [details] Patch Attachment 347874 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8951985 New failing tests: fast/scrolling/scrollbar-style-external-mouse.html Created attachment 347890 [details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347874 [details] Patch Attachment 347874 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8951617 New failing tests: fast/scrolling/scrollbar-style-external-mouse.html Created attachment 347891 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 347874 [details] Patch Attachment 347874 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8952055 New failing tests: fast/scrolling/scrollbar-style-external-mouse.html Created attachment 347892 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347874 [details] Patch Attachment 347874 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8955887 New failing tests: fast/scrolling/scrollbar-style-external-mouse.html Created attachment 347917 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 347930 [details]
Patch
What is happening (In reply to Simon Fraser (smfr) from comment #18) > What is happening I believe the build and test failures should be fixed now :) Rather than creating additional SPI, can we instead swizzle [NSScroller preferredScrollerStyle] and send a NSPreferredScrollerStyleDidChangeNotification? (In reply to Sam Weinig from comment #20) > Rather than creating additional SPI, can we instead swizzle [NSScroller > preferredScrollerStyle] and send a > NSPreferredScrollerStyleDidChangeNotification? That is a good idea, I'll look into that. Thanks for reviewing! Created attachment 348030 [details]
Patch
Created attachment 348152 [details]
Patch
Created attachment 348830 [details]
Patch
Comment on attachment 348830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348830&action=review > Tools/WebKitTestRunner/TestController.h:490 > + bool m_useOverlayScrollbars { false }; Why doesn't this follow useMockScrollbars ? Comment on attachment 348830 [details] Patch Attachment 348830 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9092908 New failing tests: fast/workers/worker-exception-during-navigation.html Created attachment 348863 [details]
Archive of layout-test-results from ews203 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
(In reply to Simon Fraser (smfr) from comment #25) > Comment on attachment 348830 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348830&action=review > > > Tools/WebKitTestRunner/TestController.h:490 > > + bool m_useOverlayScrollbars { false }; > > Why doesn't this follow useMockScrollbars ? This member variable is actually not needed since we should always use the legacy scroller style when swizzling [NSScroller preferredScrollerStyle]. I will update the patch. Thanks for reviewing! Created attachment 348945 [details]
Patch
Created attachment 349479 [details]
Patch
Comment on attachment 349479 [details]
Patch
This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
|