Bug 188375

Summary:

[WPE][GTK] Handle some virtual keys commonly used on TVs

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WPE WebKit

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, ews-watchlist, zan

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zan: review+

Description Carlos Garcia Campos 2018-08-07 01:57:54 PDT

In PlatformKeyboardEvent

Comment 1 Carlos Garcia Campos 2018-08-07 02:00:12 PDT

Created attachment 346697 [details]
Patch

Comment 2 EWS Watchlist 2018-08-07 02:02:11 PDT

Attachment 346697 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:884:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Carlos Garcia Campos 2018-08-07 02:41:06 PDT

Committed r234645: <https://trac.webkit.org/changeset/234645>