Bug 188374

Summary:

REGRESSION (r233778): Text selection sometimes cannot be extended in iframes

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, ews-watchlist, frank, ivan, mark.watkins1, megan_gardner, rniwa, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Patch	none

Wenson Hsieh

Reported 2018-08-06 23:02:42 PDT

<rdar://problem/42928657>

Attachments
Patch (15.20 KB, patch) 2018-08-06 23:24 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (16.16 MB, application/zip) 2018-08-07 01:24 PDT, EWS Watchlist	no flags	Details
Patch (14.19 KB, patch) 2018-08-07 09:49 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2018-08-06 23:24:41 PDT

Created attachment 346688 [details] Patch

EWS Watchlist

Comment 2 2018-08-07 01:24:38 PDT Comment hidden (obsolete)

Comment on attachment 346688 [details] Patch Attachment 346688 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8785121 New failing tests: editing/selection/ios/fixed-selection-after-scroll.html editing/selection/ios/selection-handles-in-iframe.html editing/selection/ios/absolute-selection-after-scroll.html

EWS Watchlist

Comment 3 2018-08-07 01:24:40 PDT Comment hidden (obsolete)

Created attachment 346693 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Wenson Hsieh

Comment 4 2018-08-07 08:53:59 PDT

Hmmm, UIScriptController.longPressAtPoint doesn't appear to work in iOS 11.4 on trunk, without any internal bits (i.e. OpenSource only). When running MobileSafari against these built products, the long press text selection gesture to select a single word also does not work, so this isn't limited to the test runner. I might have to keep these tests iOS 12-only for now.

Wenson Hsieh

Comment 5 2018-08-07 09:49:40 PDT

Created attachment 346709 [details] Patch

WebKit Commit Bot

Comment 6 2018-08-07 11:32:48 PDT

Comment on attachment 346709 [details] Patch Clearing flags on attachment: 346709 Committed r234661: <https://trac.webkit.org/changeset/234661>

WebKit Commit Bot

Comment 7 2018-08-07 11:32:50 PDT

All reviewed patches have been landed. Closing bug.

Wenson Hsieh

Comment 8 2018-10-30 18:10:05 PDT

*** Bug 191081 has been marked as a duplicate of this bug. ***

Wenson Hsieh

Comment 9 2019-01-27 14:23:49 PST

*** Bug 193663 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.