| Summary: | Use a 1-byte enum class for TextDirection | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, simon.fraser, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Alex Christensen
2018-08-06 12:53:40 PDT
Created attachment 346644 [details]
Patch
Attachment 346644 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 72 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346645 [details]
Patch
Attachment 346645 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 73 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346650 [details]
Patch
Attachment 346650 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 74 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346670 [details]
Patch
Attachment 346670 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 78 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346675 [details]
Patch
Attachment 346675 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 77 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 346710 [details]
Patch
Attachment 346710 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/text/WritingMode.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/UserInterfaceLayoutDirection.h:30: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/testing/Internals.h:617: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
Total errors found: 3 in 78 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 346710 [details] Patch Clearing flags on attachment: 346710 Committed r234808: <https://trac.webkit.org/changeset/234808> All reviewed patches have been landed. Closing bug. |