| Summary: | [Nicosia] Add Nicosia::CompositionLayerTextureMapperImpl | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cgarcia, magomez, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 187385 | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2018-08-06 09:15:10 PDT
Created attachment 346632 [details]
Patch
Comment on attachment 346632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346632&action=review > Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:46 > + CompositionLayerTextureMapperImpl(); Can we make this private? > Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:53 > + CompositionState& compositionState() { return m_compositionState; } method could be const Comment on attachment 346632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346632&action=review >> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:46 >> + CompositionLayerTextureMapperImpl(); > > Can we make this private? No, because of std::make_unique<>(). >> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaCompositionLayerTextureMapperImpl.h:53 >> + CompositionState& compositionState() { return m_compositionState; } > > method could be const Can't be, because the const m_compositionState then can be bound to a non-const reference. Created attachment 346699 [details]
Patch for landing
Comment on attachment 346699 [details] Patch for landing Clearing flags on attachment: 346699 Committed r234644: <https://trac.webkit.org/changeset/234644> All reviewed patches have been landed. Closing bug. |