| Summary: | HTML parser should execute custom element reactions for setting attributes immediately after creating a custom element | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||
| Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, darin, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, koivisto, sam, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 154907, 183931, 187319 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Ryosuke Niwa
2018-08-05 18:42:47 PDT
Created attachment 346607 [details]
Fixes the bug
Created attachment 346608 [details]
Added a missing change log
Comment on attachment 346608 [details] Added a missing change log View in context: https://bugs.webkit.org/attachment.cgi?id=346608&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:216 > + m_treeBuilder->didCreateCustomOrFallbackElement(WTFMove(newElement), *constructionData); Note that the insertion step doesn't need to be split because there is no way to affect the list of open elements in the parser once we forbid document.open/write in the bug 187319. Comment on attachment 346608 [details] Added a missing change log View in context: https://bugs.webkit.org/attachment.cgi?id=346608&action=review > Source/WebCore/ChangeLog:13 > + is set or not since the precense of an element queue should not be observable in the case where we're constructing nit: presence Did you mean to r+ the patch with that comment? (In reply to Ryosuke Niwa from comment #6) > Did you mean to r+ the patch with that comment? The patch looks good to me, but maybe someone else should review since I worked on this issue in bug 188190. (In reply to Frédéric Wang (:fredw) from comment #7) > (In reply to Ryosuke Niwa from comment #6) > > Did you mean to r+ the patch with that comment? > > The patch looks good to me, but maybe someone else should review since I > worked on this issue in bug 188190. Fair enough although this code change is quite bit different from what you made in that bug. (In reply to Ryosuke Niwa from comment #8) > (In reply to Frédéric Wang (:fredw) from comment #7) > > (In reply to Ryosuke Niwa from comment #6) > > > Did you mean to r+ the patch with that comment? > > > > The patch looks good to me, but maybe someone else should review since I > > worked on this issue in bug 188190. > > Fair enough although this code change is quite bit different from what you > made in that bug. Right, let's take this then. Committed r234608: <https://trac.webkit.org/changeset/234608> Reopening to attach new patch. Created attachment 346728 [details]
Patch for landing
Comment on attachment 346728 [details]
Patch for landing
Oops, wrong bug.
Created attachment 346730 [details]
Patch for landing
Created attachment 346731 [details]
Patch for landing
Comment on attachment 346731 [details]
Patch for landing
Ugh... wrong bug again.
|