| Summary: | [WinCairo] Enable service worker | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||
| Component: | Service Workers | Assignee: | Don Olmstead <don.olmstead> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | Basuke.Suzuki, bfulgham, commit-queue, ews-watchlist, Hironori.Fujii, pvollan, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Don Olmstead
2018-08-03 12:20:57 PDT
In the Service Worker code this MSVC bug is being hit quite a bit https://developercommunity.visualstudio.com/content/problem/292128/this-captured-in-nested-lambda-when-used-in-captur.html and is preventing compilation out of the box. We've hit that in quite a few places here. Other than that it mostly compiles out of the box but there are a few __declspec issues. It looks like a similar issue with Bug 187035 and Bug 184120. Created attachment 362460 [details]
Patch
Attachment 362460 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 363293 [details]
Patch
Comment on attachment 363293 [details] Patch Attachment 363293 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11330073 New failing tests: storage/indexeddb/modern/blocked-open-db-requests-private.html Created attachment 363327 [details]
Archive of layout-test-results from ews114 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
(In reply to Build Bot from comment #7) > Created attachment 363327 [details] > Archive of layout-test-results from ews114 for mac-highsierra > > The attached test failures were seen while running run-webkit-tests on the > mac-debug-ews. > Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6 This patch is unrelated. This test was added as a SKIP in https://trac.webkit.org/changeset/242264/webkit Comment on attachment 363293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363293&action=review > Tools/DumpRenderTree/DumpRenderTreePrefix.h:39 > #if OS(WINDOWS) Should it be PLATFORM(WIN) here as well? > Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h:51 > #if OS(WINDOWS) Should it be PLATFORM(WIN) here as well? Created attachment 363340 [details]
Patch
Comment on attachment 363340 [details] Patch Clearing flags on attachment: 363340 Committed r242279: <https://trac.webkit.org/changeset/242279> All reviewed patches have been landed. Closing bug. |