Bug 188303

Summary: Return extracted key ids as an optional
Product: WebKit Reporter: Charlie Turner <cturner>
Component: MediaAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Charlie Turner 2018-08-03 05:17:00 PDT 
Return extracted key ids as an optional
Comment 1 Charlie Turner 2018-08-03 05:28:57 PDT 
Created attachment 346473 [details]
Patch
Comment 2 Charlie Turner 2018-08-03 06:14:24 PDT 
Created attachment 346475 [details]
Patch

Fix build error reported from iOS bot
Comment 3 Charlie Turner 2018-08-03 07:50:52 PDT 
Created attachment 346482 [details]
Patch

Fix more build errors reported from iOS bot
Comment 4 Charlie Turner 2018-08-03 08:16:02 PDT 
Created attachment 346486 [details]
Patch

Fix more iOS build errors, even though keyIDs() never returns a nullopt, I am still performing extra checking for the absence of a value in case FPS at some point starts handling init data types that do not guarantee key IDs
Comment 5 Charlie Turner 2018-08-03 08:33:13 PDT 
Created attachment 346488 [details]
Patch

It was not necessary to percolate the sentinel complication throughout the FairPlayStreaming module
Comment 6 Charlie Turner 2018-08-03 08:53:22 PDT 
Created attachment 346490 [details]
Patch

More iOS build errors
Comment 7 Darin Adler 2018-08-03 13:49:30 PDT 
Comment on attachment 346490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346490&action=review

> Source/WebCore/testing/MockCDMFactory.cpp:286
> +    if (!keyIDs || (keyIDs && keyIDs.value().isEmpty())) {

No need to use && here.

    if (!keyIDs || keyIDs.value().isEmpty()) {
Comment 8 Charlie Turner 2018-08-06 04:40:52 PDT 
Created attachment 346624 [details]
Patch

Move the key ids rather than attempting a copy, which fails with the Vector of Refs, added logical cleanup suggested by Darin.
Comment 9 WebKit Commit Bot 2018-08-06 09:47:28 PDT 
Comment on attachment 346624 [details]
Patch

Clearing flags on attachment: 346624

Committed r234603: <https://trac.webkit.org/changeset/234603>
Comment 10 WebKit Commit Bot 2018-08-06 09:47:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-08-06 09:48:30 PDT 
<rdar://problem/42971214>