Bug 188277

Summary: Move queue processing logic from CustomElementReactionStack to CustomElementReactionQueue
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187805    
Attachments:
Description Flags
Cleanup wenson_hsieh: review+

Description Ryosuke Niwa 2018-08-02 14:19:51 PDT 
CustomElementReactionStack is supposed to be a simple class which simply invokes the logic in CustomElementReactionQueue.
Move more code from CustomElementReactionStack to CustomElementReactionQueue to that end.
Comment 1 Ryosuke Niwa 2018-08-02 14:22:28 PDT 
Created attachment 346417 [details]
Cleanup
Comment 2 Wenson Hsieh 2018-08-02 14:37:57 PDT 
Comment on attachment 346417 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=346417&action=review

rs=me

> Source/WebCore/dom/CustomElementReactionQueue.h:97
> +    CustomElementReactionQueue::ElementQueue* m_queue { nullptr }; // Use raw pointer to avoid generarting delete in the destructor.

generarting!
Comment 3 Ryosuke Niwa 2018-08-02 15:37:11 PDT 
Committed r234520: <https://trac.webkit.org/changeset/234520>
Comment 4 Radar WebKit Bug Importer 2018-08-02 15:38:36 PDT 
<rdar://problem/42876536>