Bug 188271

Summary: Reading instructionPointer from PlatformRegisters may fail when using pointer profiling
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Saam Barati 2018-08-02 12:29:15 PDT 
...
Comment 1 Saam Barati 2018-08-02 12:29:45 PDT 
<rdar://problem/42850884>
Comment 2 Saam Barati 2018-08-02 13:05:42 PDT 
Created attachment 346410 [details]
patch
Comment 3 EWS Watchlist 2018-08-02 13:09:48 PDT 
Attachment 346410 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/tools/SigillCrashAnalyzer.cpp:161:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Michael Saboff 2018-08-02 16:45:41 PDT 
Comment on attachment 346410 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2018-08-02 17:14:17 PDT 
Comment on attachment 346410 [details]
patch

Clearing flags on attachment: 346410

Committed r234528: <https://trac.webkit.org/changeset/234528>
Comment 6 WebKit Commit Bot 2018-08-02 17:14:19 PDT 
All reviewed patches have been landed.  Closing bug.