Bug 188231

Summary: JSArrayBuffer should have its own JSType
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, mark.lam, msaboff, saam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Description Keith Miller 2018-08-01 12:09:41 PDT
JSArrayBuffer should have its own JSType
Comment 1 Keith Miller 2018-08-01 12:10:09 PDT
Created attachment 346286 [details]
Patch
Comment 2 Keith Miller 2018-08-01 13:34:02 PDT
Committed r234468: <https://trac.webkit.org/changeset/234468>
Comment 3 Darin Adler 2018-08-01 18:50:48 PDT
You forgot to say why.
Comment 4 Keith Miller 2018-08-01 18:51:56 PDT
(In reply to Darin Adler from comment #3)
> You forgot to say why.

I'm going to use this in a future, larger patch, so I figured I'd break it out.
Comment 5 Saam Barati 2018-08-01 19:07:06 PDT
(In reply to Keith Miller from comment #4)
> (In reply to Darin Adler from comment #3)
> > You forgot to say why.
> 
> I'm going to use this in a future, larger patch, so I figured I'd break it
> out.

For posterity when people look up this bug, it gives us a single load+compare in jsDynamicCast.
Comment 6 Radar WebKit Bug Importer 2018-08-01 20:26:31 PDT
<rdar://problem/42840295>