| Summary: | Convert calc-related enums to 8-bit enum classes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2018-07-31 22:33:41 PDT
Created attachment 346261 [details]
Patch
Attachment 346261 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/CalculationValue.h:186: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
ERROR: Source/WebCore/platform/CalculationValue.h:203: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
ERROR: Source/WebCore/platform/CalculationValue.h:218: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
ERROR: Source/WebCore/platform/CalculationValue.h:229: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5]
Total errors found: 4 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 346261 [details] Patch Attachment 346261 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8726306 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html Created attachment 346300 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 346261 [details] Patch Clearing flags on attachment: 346261 Committed r234506: <https://trac.webkit.org/changeset/234506> All reviewed patches have been landed. Closing bug. |