| Summary: | [GStreamer] Make sure that first buffer running time is 0 in GStreamerMediaStreamSource | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thibault Saunier <tsaunier> | ||||||
| Component: | New Bugs | Assignee: | Thibault Saunier <tsaunier> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alex, commit-queue, lforschler, pnormand | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Thibault Saunier
2018-07-31 16:36:25 PDT
Created attachment 346222 [details]
Patch
Comment on attachment 346222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346222&action=review LGTM, just fix the typo. > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:512 > + auto pad = adoptGRef(gst_element_get_static_pad(self->videoSrc, "src")); Probably this is a small typo and you wanted to use audioSrc. Created attachment 346273 [details]
Patch
Fix typo
Comment on attachment 346273 [details] Patch Clearing flags on attachment: 346273 Committed r234457: <https://trac.webkit.org/changeset/234457> All reviewed patches have been landed. Closing bug. |