| Summary: | Hardcode some system colors to avoid fingerprinting exposure | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> |
| Component: | CSS | Assignee: | Timothy Hatcher <timothy> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bdakin, bfulgham, commit-queue, ews-watchlist, ggaren, megan_gardner, rniwa, thorton, webkit-bug-importer, wilander |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=210719 | ||
| Attachments: | |||
|
Description
Timothy Hatcher
2018-07-31 12:05:58 PDT
Created attachment 346186 [details]
Patch
Comment on attachment 346186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346186&action=review > Source/WebCore/rendering/RenderThemeMac.mm:761 > + return 0xFF7DADD9; We can’t get these un-accented from the system? Comment on attachment 346186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346186&action=review >> Source/WebCore/rendering/RenderThemeMac.mm:761 >> + return 0xFF7DADD9; > > We can’t get these un-accented from the system? Not that I could find. Comment on attachment 346186 [details] Patch Attachment 346186 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8713260 New failing tests: fast/css/apple-system-control-colors.html css3/color-filters/color-filter-ignore-semantic.html Created attachment 346194 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 346186 [details] Patch Attachment 346186 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8713312 New failing tests: fast/css/apple-system-control-colors.html css3/color-filters/color-filter-ignore-semantic.html Created attachment 346196 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 346186 [details] Patch Attachment 346186 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8714356 New failing tests: fast/css/apple-system-control-colors.html css3/color-filters/color-filter-ignore-semantic.html Created attachment 346209 [details]
Archive of layout-test-results from ews117 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 346210 [details]
Patch
Comment on attachment 346210 [details] Patch Attachment 346210 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8715603 New failing tests: fast/css/apple-system-control-colors.html fast/css/test-setting-canvas-color.html Created attachment 346218 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 346210 [details] Patch Attachment 346210 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8715638 New failing tests: fast/css/apple-system-control-colors.html fast/css/test-setting-canvas-color.html Created attachment 346219 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 346210 [details] Patch Attachment 346210 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8715558 New failing tests: fast/css/apple-system-control-colors.html fast/css/test-setting-canvas-color.html Created attachment 346221 [details]
Archive of layout-test-results from ews117 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 346254 [details]
Patch
Comment on attachment 346254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346254&action=review > Source/WebCore/rendering/RenderThemeMac.mm:768 > + return Color(0x4C1AA9FF, Color::Semantic); You could neaten this up with the ternary operator but maybe this is easier to read. Comment on attachment 346254 [details] Patch Clearing flags on attachment: 346254 Committed r234466: <https://trac.webkit.org/changeset/234466> All reviewed patches have been landed. Closing bug. |