| Summary: | [GStreamer] Dynamically adjust blocksize | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Charlie Turner <cturner> | ||||||||
| Component: | WebKitGTK | Assignee: | Charlie Turner <cturner> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bugs-noreply, calvaris, commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=188193 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Charlie Turner
2018-07-31 06:50:57 PDT
Created attachment 346165 [details]
Patch
Depends on https://bugs.webkit.org/show_bug.cgi?id=188193 landing first. Comment on attachment 346165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346165&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:60 > + static constexpr int growBlocksizeLimit { 1 }; > + static constexpr int growBlocksizeCount { 1 }; > + static constexpr int growBlocksizeFactor { 2 }; > + static constexpr float reduceBlocksizeLimit { 0.20 }; > + static constexpr int reduceBlocksizeCount { 2 }; > + static constexpr float reduceBlocksizeFactor { 0.5 }; These should be prefixed with s_ > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:784 > + m_reduceBlocksizeCount = m_increaseBlocksizeCount = 0; Please, write this in two lines. Created attachment 346374 [details]
Patch
Fix code style violations
Created attachment 346375 [details]
Patch
Fix code style violations
Comment on attachment 346375 [details] Patch Clearing flags on attachment: 346375 Committed r234498: <https://trac.webkit.org/changeset/234498> All reviewed patches have been landed. Closing bug. |